Long time knitter here!
I taught DS7 to knit at the start of the year because he was curious about it. He hasn't kept up with it, and that's fine. But he enjoyed learning, and it was something different.
I see no problem with it, provided it's not holding kids back. It is an awfully useful skill to learn! Kids who are able to relax into it and who have good work ethics will do well at it, I predict. Kids who are tense perfectionists will struggle and get frustrated, though they may overcome it, and it might be a darn good lesson for them. Knitting really helped me accept that perfect wasn't necessary.
